[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: "svn diff" crashes when binary files differ

From: Sander Striker <striker_at_apache.org>
Date: 2003-02-25 01:39:18 CET

> From: Julian Foad [mailto:julianfoad@btopenworld.com]
> Sent: Tuesday, February 25, 2003 1:39 AM

> Julian Foad wrote:
> > "svn diff" crashes (or exits with error when using external diff) when I
> > type the commands listed below.
> ...
> > ~/src/subversion/notes/logo> svn diff
> > Segmentation fault
> ...
>
> I have just updated to revision 5076 and this crash still happens.

It's a different bug. It's real simple, '\n' is never encountered in
the binary data before a '\0'. I'll rehash the svn_diff_file token
stuff to account for this tomorrow. Might aswell switch to mmapping
then too. Anyhow, this bug shows it's ugly head because we are running
text diff on binary data, which shouldn't happen in the first place.
I thought we had an issue on this which was already closed, but am
not sure.

Sander 'getting sleep first'

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 25 01:40:00 2003

This is an archived mail posted to the Subversion Dev mailing list.