[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5001 - in trunk/subversion: include libsvn_wc libsvn_client libsvn_delta

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-02-22 18:19:45 CET

On Saturday, February 22, 2003, at 12:15 PM, Greg Hudson wrote:

> On Sat, 2003-02-22 at 12:11, Garrett Rooney wrote:
>> but the cancellation editor is in svn_delta.h right now. the only
>> thing left in svn_cancel.h is the typedef for svn_cancel_func_t,
>> that's
>> what greg is proposing we move to svn_types.h.
>
> Ah, I failed to understand. Still, it seems like it belongs right next
> to the declaration of svn_delta_get_cancellation_editor.

see, i disagree on that point. there's nothing about the cancellation
callback that implies it has anything to do with editors, that's just
an implementation detail. i don't see why svn_client.h should be
including svn_delta.h just to get a typedef that has nothing to do with
libsvn_delta other than being used by an editor that lives in
libsvn_delta.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 22 18:20:26 2003

This is an archived mail posted to the Subversion Dev mailing list.