Re: svn commit: rev 5006 - in trunk/subversion: include libsvn_ra_dav libsvn_auth

On Fri, Feb 21, 2003 at 12:20:08PM -0600, sussman@tigris.org wrote:
> Author: sussman
> Date: 2003-02-21 12:19:39 -0600 (Fri, 21 Feb 2003)
> New Revision: 5006
>
> Modified:
> trunk/subversion/include/svn_auth.h
> trunk/subversion/libsvn_auth/auth.c
> trunk/subversion/libsvn_ra_dav/session.c
> Log:
>
> Implement a simple caching system in libsvn_auth (and simplify/cleanup
> some stuff in the process.)
>
> Now the same auth_baton can be used over and over with multiple
> svn_client_foo() calls, and each subsequent RA session will receive
> cached creds when it calls first_creds().

Nope... please revert.

Recall that fetching credentials of a specific kind is *also* keyed by
parameters that may have been set using svn_auth_set_parameter(). If the RA
layer sets a Basic Auth Realm, then asks for credentials, it does *not* want
credentials come from some other realm.

What is the basis for this change? Why was a cache needed? Maybe we can find
a different way to solve what you were trying to fix.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org