[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Disable fsync at transaction commit

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-02-22 05:46:02 CET

Branko Čibej wrote:

>Greg Stein wrote:
>
>
>
>>On Sat, Feb 22, 2003 at 04:48:25AM +0100, Branko Cibej wrote:
>>
>>
>>
>>
>>>...
>>>The log message (if I were to commit this patch) would look a bit like
>>>this (see, Karl, I /told/ you :svn_config_create should be publc :-) :
>>>
>>>
>>>
>>>
>>Blah. Just use a hash table of options. svn_config should be about reading
>>config files, not a replacment for simple name/value option pairs.
>>
>>"Hey! I've got this hammer here, and *that* looks like a nail! WHAM! WHAM!"
>>
>>:-)
>>
>>Seriously... just use a hash. Forget the svn_config_create stuff.
>>
>>
>>
>The point of using an svn_config_t is that you can put
>FS-backend-specific options in fs-backend-specific sections, without
>having to know in advance which backend you're using. Yes, I know we
>have only the BDB backend at the moment. I'm sure gat appreciates every
>BDB-specific top-level interface we add. :-)
>
>
Besides, I *hate* using APR hashes for such things, because you have to
cast the values all over the place...

void *value;
const char *real_value;
apr_hash_get(foo, &value);
reap_value = value;

Blech! Give me svn_config_get any day. (And I might just go and change
that interface to return a const char* instead of returning it by
reference. I don't know what I was thinking when I wrote that.)

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 22 05:46:40 2003

This is an archived mail posted to the Subversion Dev mailing list.