[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Disable fsync at transaction commit

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-02-22 05:34:26 CET

On Sat, Feb 22, 2003 at 04:48:25AM +0100, Branko Cibej wrote:
> The log message (if I were to commit this patch) would look a bit like
> this (see, Karl, I /told/ you :svn_config_create should be publc :-) :

Blah. Just use a hash table of options. svn_config should be about reading
config files, not a replacment for simple name/value option pairs.

"Hey! I've got this hammer here, and *that* looks like a nail! WHAM! WHAM!"


Seriously... just use a hash. Forget the svn_config_create stuff.

> +++ subversion/include/svn_fs.h (working copy)
> @@ -30,6 +30,7 @@
> #include "svn_error.h"
> #include "svn_delta.h"
> #include "svn_io.h"
> +#include "svn_config.h"

Oof. Just use a hash... just use a hash...


Hmm. It seems like there are two pieces here. One piece that passes config
to affect the creation, and one piece to pass params during normal
operation. But I didn't see any of the latter, so maybe the patch can be
trimmed back to just the creation params [for now] ?

We can always come back at some future point to add runtime params.


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 22 05:30:10 2003

This is an archived mail posted to the Subversion Dev mailing list.