Re: When to call txn_checkpoint().

On Fri, Feb 21, 2003 at 06:44:39AM +0100, Branko Cibej wrote:
> cmpilato@collab.net wrote:
> >Karl Fogel <kfogel@newton.ch.collab.net> writes:
> >>So, would anyone object to my removing the second call? (Yes, I'm
> >>volunteering to do the change, run stress.pl and the test suite, etc
> >>:-). )
> >
> >That's fine. Go for it.

Yup, sounds like a great plan!

It might be helpful to go ahead and increase the values a bit. We increase
the default lock counts and stuff, too, if I recall correctly. It would be
"even nicer" to have admin-tunable, but the code defaults can help out.

> >>This was Greg Stein's idea during a phone call. It's possible he
> >>didn't know at the time what txn_checkpoint's parameters do, and might
> >>well prefer Solution 1 himself (I know I do, now that I've taken a
> >>closer look at how txn_checkpoint works).

Had no idea they were tunable. I figured it was binary: call it to
checkpoint, don't call to not checkpoint. With those params in there? Hoo
yah! Great.

> >>The idea is to move the txn_checkpoint() calls out of the regular FS
> >>code paths entirely, and instead make it a public API function of the
> >>Berkeley back end:
> >>
> >> svn_error_t *svn_fs_berkeley_checkpoint (const char *path,
> >> apr_pool_t *pool);
> >
> >-1, absolutely not. The longterm goal here is to *lose*
> >database-specific public API calls.
> >
> >
> I coudn't agree more. What a horrible idea!

It is a fine idea IFF txn_checkpoint didn't have the params. Exposing that
function gives the application a way to better control the times that you
want to spend the effort to do the checkpoint. The other alternative to the
API would have been some kind of cron job (even worse!) or sticking with
some kind of fine-grained happens-way-too-often checkpointing.

But given the params? Heck ya. Forget the new function.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org