Re: svn: system(' svn-commit.tmp') returned 32512

On Fri, Feb 21, 2003 at 04:02:26PM -0800, Ben Collins-Sussman wrote:
> Craig Longman <craigl@begeek.com> writes:
>
> > actually, the EDITOR was not set (i'm running bash on linux), but if i
> > _provide_ an EDITOR or a -m then it works great! fwiw, the output
> > from not having EDITOR set and having EDITOR set to "" appears to be
> > identical.
>
> Wow, we have genuine regression bug. I just unset EDITOR on my
> FreeBSD box, and instead of seeing the usual error about "you must use
> -F, -m or set EDITOR", I get the same error as you:
>
> svn: Error calling external program
> svn: Commit failed (details follow):
> subversion/clients/cmdline/util.c:201: (apr_err=200012)
> svn: system(' svn-commit.tmp') returned 32512
>
> Subversion should *not* be trying to run system(EDITOR) if the
> variable is undefined.

If --with-editor is not passed to configure, SVN_CLIENT_EDITOR is set
to the empty string, which becomes the default. Would someone please
test and, if the tests are successful, apply the following patch?

Index: configure.in
===================================================================
--- configure.in (revision 5009)
+++ configure.in (working copy)
@@ -282,12 +282,12 @@
       AC_MSG_ERROR([--with-editor requires an argument.])
     else
       SVN_CLIENT_EDITOR=$withval
+ AC_DEFINE_UNQUOTED(SVN_CLIENT_EDITOR, "$SVN_CLIENT_EDITOR",
+ [The path of a default editor for the client.])
+
     fi
 
 ])
-
-AC_DEFINE_UNQUOTED(SVN_CLIENT_EDITOR, "$SVN_CLIENT_EDITOR",
- [Define to the path of a default editor for the client.])
 
 MOD_ACTIVATION="-a"
 AC_ARG_ENABLE(mod-activation,

Matt

-- 
Oink!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org