Karl Fogel <kfogel@newton.ch.collab.net> writes:
> Garrett Rooney <rooneg@electricjellyfish.net> writes:
> > >I thought we were planning to cache them in there. Garrett, does that
> > >match your understanding?
> >
> > we cache an authentication baton now, i don't know what needs to be
> > done to the baton to make it cache the password, but i thought it
> > would do that automatically...
>
> Hmmm. That sounds like there's a bug then, no?
>
> Ben will know the answer to this off the top of his head :-). He was
> up till three last night, so he just hasn't seen this mail yet.
Heh, this isn't a bug, it's just a libsvn_auth design oversight.
Our main commandline client:
creates a ctx object
creates an auth_baton with various providers
runs a single subcommand
calls first_creds, next_creds, next_creds ...
exits
There's simply no caching design here at all, which would be needed by
long-running GUI clients.
What's happening with a GUI client is this:
creates a ctx object
creates an auth_baton with various providers
run many subcommands
calls first_creds, next_creds, next_creds ...
calls first_creds, next_creds, next_creds ...
calls first_creds, next_creds, next_creds ...
exits
I think the solution here is simple: the auth_baton can cache the last
returned set of credentials (of each type). Then we change first_creds()
to always return the cache, if available. Pretty easy.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 20 20:52:56 2003