[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4848 - trunk/subversion/bindings/swig

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2003-02-18 19:25:48 CET

Jesper Steen Møller <jesper@selskabet.org> writes:

> Daniel Rall wrote:
>
> >Greg Stein <gstein@lyra.org> writes:
> >
>
> >>On Tue, Feb 11, 2003 at 05:57:46PM -0600, dlr@tigris.org wrote:
> >>
>
> >>>...
> >>>+++ trunk/subversion/bindings/swig/apr.i Tue Feb 11 17:57:29 2003
> >>>...
> >>> /* -----------------------------------------------------------------------
> >>> handle apr_file_t *
> >>> */
> >>>@@ -153,7 +162,7 @@
> >>> apr_file_t ** is always an OUT param
> >>> */
> >>> -%typemap(in,numinputs=0) apr_file_t ** (apr_file_t *temp)
>
> >>>+%typemap(python, in, numinputs=0) apr_file_t ** (apr_file_t *temp)
> >>> "$1 = &temp;";
> >>>
>
> >>I see nothing Python specific there. Why was this change made?
> >>
>
> >
> >Well, we were on a roll with breaking the build and just didn't see a
> >need to stop ... fixed this one in r4866. There may be others.
> >
>
> It is Python specific since it uses "numinputs=0", thus relying on
> t_output_helper to return the result in a tuple.
>
> In Java, the binding must/should work by returning the output variable
> in a in/out parameter, which is done by using an array of
> SWIGTYPE_p_apr_file_t of length one - SWIG does this automatically,
> but the typemap above overrides (incorrectly).
>
>
> I'm sorry if my patches otherwise broke the build - I hadn't imagined
> that it could hurt the Python binding to add the qualifier.
>
>
> I'd better install Python here and test with it in the future.

Jesper, though it was me who rolled back this portion of your patch,
would you mind correcting it? You seem to have a good handle on SWIG.
Thanks!

- Dan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 18 19:26:11 2003

This is an archived mail posted to the Subversion Dev mailing list.