[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] cancellation, take one

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-02-17 23:42:05 CET

Philip Martin wrote:

>Garrett Rooney <rooneg@electricjellyfish.net> writes:
>
>
>
>>* subversion/libsvn_subr/cancel.c: new file, implements the
>>* cancellation editor.
>>
>>
>
>I'm a little worried about the organisation of this stuff. The
>cancellation editor is an svn_delta_editor_t editor but you have
>implemented it in libsvn_subr. Doesn't that introduce a cyclic
>dependency? You have libsvn_subr call svn_delta_default_editor but
>libsvn_delta already uses libsvn_subr routines.
>
There's absolutely nothing wrong with that kind of dependencies. Any
normal linker can resolve them; at worst, you'll get one of those files
on the link line twice.

>>Index: subversion/include/svn_cancel.h
>>===================================================================
>>--- subversion/include/svn_cancel.h (working copy)
>>+++ subversion/include/svn_cancel.h (working copy)
>>@@ -0,0 +1,51 @@
>>+/**
>>+ * @copyright
>>+ * ====================================================================
>>+ * Copyright (c) 2000-2003 CollabNet. All rights reserved.
>>
>>
>
>2000-2003? Should a new file use that or just 2003?
>
All our copyright headers are the same in all files, for good reason --
they're updated by a script.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 17 23:42:48 2003

This is an archived mail posted to the Subversion Dev mailing list.