Re: [PATCH] cancellation, take one

On Monday, February 17, 2003, at 01:03 PM, Philip Martin wrote:

> Garrett Rooney <rooneg@electricjellyfish.net> writes:
>
>> * subversion/libsvn_subr/cancel.c: new file, implements the
>> * cancellation editor.
>
> I'm a little worried about the organisation of this stuff. The
> cancellation editor is an svn_delta_editor_t editor but you have
> implemented it in libsvn_subr. Doesn't that introduce a cyclic
> dependency? You have libsvn_subr call svn_delta_default_editor but
> libsvn_delta already uses libsvn_subr routines.

i was wondering about that myself... perhaps
svn_cancel_get_cancelation_editor should move into libsvn_delta
somewhere? what do people think?

thanks for the comments on main.c... that part of the patch hadn't
been polished up yet, since i hadn't planned on committing it until
more of this stuff had been done.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 17 19:09:18 2003