[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] cancellation, take one

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-02-16 08:12:14 CET

ok, i was bored this weekend and tired of real work, so i decided to
start on the cancellation stuff earlier than i had originally planned.

here's a proof of concept patch that adds a cancellation editor, which
can be wrapped around any other editor to insert calls to the client
provided cancellation callback function to see if we should stop the
editor's drive.

so far i've only tried this with repos to repos diffs, but it seems to
work ok for that. the usual warnings, relatively untested code, could
eat your dog and email your homework to your worst enemy...

i haven't even put this through make check yet, but i just wanted to
get people's opinions. does this seem like a reasonable approach?
something that just occurred to me is that
svn_cancel_get_cancellation_editor should be smarter, it can check to
see if the cancellation function is NULL, and if so just return the
underlying editor it was passed, with no extra cancellation editor
layered on top. that would also remove the checks in this patch that
ensure the cancellation function is non-null before calling it.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sun Feb 16 08:13:06 2003

This is an archived mail posted to the Subversion Dev mailing list.