Re: svn commit: rev 4882 - trunk/subversion/libsvn_fs

"Sander Striker" <striker@apache.org> writes:
> > Ben's solution has the nice property that the baton's state remains
> > the same (and useable) no matter how many times the txn is retried.
>
> Bah humbug. Same goes for my solution.

They're not quite equivalent. In one, *all* the state associated with
making a digest remains localized to the close function -- the baton
remains unaffected. There's a certain cleanliness to that.

> Why copy the unfinalized context, finalize, on every retry when you don't
> have to? In the end, it is about the final digest, not the unfinalized
> apr md5 context.

Well, it's not like finalizing is our bottleneck here :-).

If you feel strongly about it, I wouldn't object to a change. I only
mildly prefer the current solution, and it certainly has its own
wonkinesses. Go for it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 13 23:30:05 2003