[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

tools/backup/hot-backup.py.in

From: Michael Price <mprice_at_atl.lmco.com>
Date: 2003-02-13 19:56:33 CET

Is it just me or is step 8 in the hot-backup.py script bogus?

The comment for the num_backups variable is:

  # Number of backups to keep around

However, the comment for step 8 in the script is:

  # Step 8: finally, remove the repository back that's NUM_BACKUPS older
  # than the one we just created. If there are multiple versions of
  # this repos backup, remove them too.

Now, this comment does accurately reflect what the code actually does,
but this conflicts with the comment for num_backups.

The script doesn't actually keep around that many backups. Instead, it
checks for a backup and if you happen to have one num_backups older then
it gets removed. If you don't happen to have one (which is often the
case) then nothing is removed.

So am I crazy or what?

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 13 19:59:04 2003

This is an archived mail posted to the Subversion Dev mailing list.