Re: svn commit: rev 4824 - in trunk/subversion: svnadmin include libsvn_subr svnlook clients clients/cmdline tests/libsvn_subr svnserve svnversion

Karl Fogel wrote:

>Branko ÄŒibej <brane@xbc.nu> writes:
>
>
>>As you might have guessed, given the last paragraph above, I don't agree
>>with putting this into libsvn_subr. It doesn't belong there. We need a
>>separate library that contains only utilities for our command-line
>>clients. There are other things that should go there; for instance,
>>svn_path_internal_style and svn_path_local_style don't belong in
>>libsvn_subr, nor does opt.c. I also strongly suspect that the
>>command-line client support library should _only_ exist as a static lib,
>>not a shared one. I'd suggest refactoring all this into a new directory
>>under subversion/clients.
>>
>>
>
>I think that's fine. Never meant to claim this is a good solution,
>just that it's better,
>

>to some of us :-),
>
/me lets fly a loud raspberry

> than the previous solution.
>
>However, we also have many more important fish to fry, so refactoring
>this isn't on the top of my personal stack either :-(.
>
>
Oh sure, I wasn't suggesting you should do that right now. I'd just like
to point out it's something to do. Maybe I'll file an issue.

-- 
Brane ÄŒibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org