On Mon, Feb 10, Karl Fogel wrote:
> Olaf Hering <olh@suse.de> writes:
> > I added a (global) svn:keyword on 'svn add foo.c' with the patch below.
> >
> > ~/.subversion/config:
> > [properties_on_add]
> > keywords = foo bar Id HostURL
> >
> > However, it would make more sense to specify that per repository. The
> > right place for that seems to be ~/subversion/servers.
> > I do not see how to retrieve the URL in the add-cmd.c and match it
> > against the configured servers.
> >
> > Is such a change acceptable?
>
> It looks like you are offering the patch as a substitute for a precise
> prose description of the change. Please just use prose instead :-).
> Then it would be much easier to comprehend, quote, modify, etc, in the
> context of a mailing list discussion.
>
> If I understand the proposal correctly, I don't find it very
> compelling, not pre-1.0 imho.
Ok, well, to say it again:
Is there a way to do a 'svn proset svn:keywords Id file' automatically
when on runs 'svn add file'? And if there is no such feature, can it be
added on a per repository base, configureable via ~/.subversion/servers
(I assume thats the users repository "database")?
The problem I see right now, how do I retrieve the URL on svn add? It
seems 'svn info' gets it in some way, and even 'svn add' must know it
somehow. Have to dig depper in the code.
> (If I'm wrong, and the patch really is meant for application, then see
> the HACKING file for guidance. Specifically, the "#ifdef olh"s have
> to go :-); it needs a log message; the new function needs to be
> documented; the new function should be static, needs no independent
> prototype, and needs no "svn_cl__" prefix; etc.)
Sure, the patch was not meant for inclusion, just a hack to make our
guys happy.
Gruss Olaf
--
A: No.
Q: Should I include quotations after my reply?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 10 20:56:06 2003