[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4805 - in trunk: . subversion/tests/libsvn_delta

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-02-09 16:27:07 CET

On Sunday, February 9, 2003, at 08:41 AM, philip@tigris.org wrote:

> Author: philip
> Date: 2003-02-09 07:40:50 -0600 (Sun, 09 Feb 2003)
> New Revision: 4805
>
> Added:
> trunk/subversion/tests/libsvn_delta/diff-diff3-test.c
> Modified:
> trunk/build.conf
> Log:
> If we are to enable the internal diff library then we ought to have
> some regression tests. So this tests some basic behaviour, but does
> not test the conflict handling. Some of these tests fail.

first off, thank you thank you thank you for putting these together, we
absolutely need them.

second, how did you come up with the results for the
two_way_unified_suspect tests? are you just comparing against the
output from gnu diff? at least the first 'failure' in there seems to
produce a valid unified diff, it's just showing slightly more context
than you're expecting.

perhaps these tests shouldn't be comparing against a cannonical 'good
result', but instead should be using patch to try to reconstruct the
original file from the diff, and verifying that it matches.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Feb 9 16:27:50 2003

This is an archived mail posted to the Subversion Dev mailing list.