[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4739 - in trunk/subversion: svnadmin svnlook clients clients/cmdline tests/libsvn_subr svnserve svnversion

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-02-07 23:52:57 CET

On Friday, February 7, 2003, at 05:02 PM, Karl Fogel wrote:

> Branko ╚ibej <brane@xbc.nu> writes:
>> I wish people would stop getting the jitters every time they see
>> actual
>> code in a file ending with .h. It's perfectly valid C, and accepted
>> practice for certain situations. But all right, I can rename the file
>> to
>> end in .c, if ti makes you feel better.
>
> No one's arguing that it's not valid C, and whether it is "accepted
> practice" is, of course, not a question that can be resolved by
> asserting that it is :-).
>
> I'd say, don't bother to rename the file. When I get back to Chicago,
> I'll move the function definition to some reasonable place and put the
> prototype in a header, unless you've beaten me to it. (This isn't a
> crisis, after all, only an annoyance.)

well, the fact that this code makes svn fail to function on mac os x is
a little more concerning to me... would anyone object to me removing
the error checking around the setlocale call like it was before? as
far as i can tell there is no way to get 'setlocale (LC_ALL, "")' to
work there, and as a number of our developers (and users) use that
operating system, i'd prefer to 'fix' it soon.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 7 23:53:37 2003

This is an archived mail posted to the Subversion Dev mailing list.