[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4739 - in trunk/subversion: svnadmin svnlook clients clients/cmdline tests/libsvn_subr svnserve svnversion

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-02-07 21:12:14 CET

Greg Hudson wrote:

>On Tue, 2003-02-04 at 21:51, Branko Čibej wrote:
>>Correctness first, as usual. I'll fix these issues presently, but even
>>deciding where to put such a function (it doesn't fit in any of our
>>libraries) takes some thought.
>I realize there is a difficult problem to solve here, but (speaking as
>an individual developer) please do not commit code like this to the
>trunk as an interim solution. Putting function definitions in header
>files is a gross violation of our coding methodology.

I wish people would stop getting the jitters every time they see actual
code in a file ending with .h. It's perfectly valid C, and accepted
practice for certain situations. But all right, I can rename the file to
end in .c, if ti makes you feel better.

Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 7 21:12:57 2003

This is an archived mail posted to the Subversion Dev mailing list.