svn_filesize_t (was Re: Issue 1031 (gcc3.3 compile warnings) is out of date)

I'm concerned about issue 639, actually. I don't remember any
discussion of it on the list, and it seems like a rather fundamental
change. The issue says:

  "However, our sizes should not be related to the operating system
  limits. We should be targeting a 64-bit file size (and offsets into
  that)."

But there is no justification for that statement. We have no problem
with file formats, since we never use fixed fields in file formats
(Berkeley DB might use fixed fields internally, but that's not under our
control). apr_off_t doesn't appear in our svn_client or svn_wc API, and
appears in the svn_fs API in exactly one place (svn_fs_file_length). So
it seems like issue 639 is going to create a lot of code for no stated
benefit.

(Incidentally, on most 32-bit *BSD systems, off_t is 64 bits and size_t
is 32 bits. Since some of the CollabNet people are FreeBSD users, I
don't think any warnings on Windows are due to 64-bit off_t being
unusual.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 6 19:27:34 2003