Re: "serve.c" and "text_deltas" parameter of svn_repos_begin_report

On Mon, 2003-02-03 at 17:36, Julian Foad wrote:
> In svnserve/serve.c the two functions "switch_cmd" and "diff" are
> identical except that one passes TRUE and the other FALSE to the
> "text_deltas" parameter of svn_repos_begin_report.

I don't really believe in factoring out code which happens to be similar
despite accomplishing rather different functional goals. "switch" and
"diff" are very dissimilar operations (certainly more different than
"switch" and "update"); they just happen to accept the same parameters.
A change to "switch" is more likely than not to be inapplicable to
"diff", so combining the implementations doesn't make maintenance any
easier.

Now, I would be willing to accept code to factor out, say, the 13 lines
of code which check for a valid versus_url. That would apply to
link_path as well as switch_cmd and diff.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 5 23:56:23 2003