[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] pushing client config information into svn_client_ctx_t

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-02-05 04:58:44 CET

here's the beginnings of pushing the client's config options into
svn_client_ctx_t and passing it down into the library functions that
need it, rather than having the libraries read them in themselves
whenever they need the info. it's not done, but i've set things up so
the rest shouldn't take long, i just need to push the config options
far enough down into the ra layers to replace the config options being
used there.

the general idea is we add an apr_hash_t member to svn_client_ctx_t
which is keyed off of const char *'s and holds svn_config_t's. the
client loads the config options it cares to provide at startup, with
each 'file' worth of options going under that key (i.e. the config from
~/.subversion/config has the key "config"). the ra layer's open
function takes this type of hash as an argument (since we can't forsee
what kind of config options ra layers will need, and passing it in at
open time means the ra layer can cache it in the session), and other
libraries (libsvn_wc or libsvn_subr so far) just have the function
which needs it accept the a svn_config_t argument (which can be NULL).

anyway, i just wanted to see if anyone had any ideas about this before
i take it any further. note that this is /very/ lightly tested...
i've run 'svn st' and it seems to be picking up my default ignores
fine, so it at least sort of works, but anything further than that very
well could crash, eat your homework, kill your dog...

thanks,

-garrett

(oh, and i promise after this i'll actually work on that cancelation
thing that was the motivation for all this stuff ;-) )

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Wed Feb 5 04:59:29 2003

This is an archived mail posted to the Subversion Dev mailing list.