[PATCH] Fix issue 1118 - Third Edition (with separate functions)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

[No problem rewriting this -- pretty much just a matter of search and
replace.]

Fix for issue 1118: new functions to properly escape whitespace in XML
attribute values, rename existing functions to indicate that they should
only be used on CDATA, and update all callers of svn_xml_escape_* to use
the new functions.

* libsvn_subr/xml.c
* include/svn_xml.h
  (xml_escape, xml_escape_cdata): Rename xml_escape to xml_escape_cdata.
  (svn_xml_escape_string, svn_xml_escape_cstring,
    svn_xml_escape_stringbuf): Rename to svn_xml_escape_cdata_*, and
    document that these are not suitable for escaping attribute values.
  (xml_escape_cdata): Don't escape single- and double-quotes.
  (xml_escape_attr, svn_xml_escape_attr_string,
    svn_xml_escape_attr_cstring, svn_xml_escape_attr_stringbuf):
    New functions, like xml_escape_cdata* but suitable for attributes.

* mod_dav_svn/deadprops.c
* clients/cmdline/log-cmd.c
* libsvn_ra_dav/commit.c
* libsvn_ra_dav/fetch.c:
    Update callers of svn_xml_escape_* to use either svn_xml_escape_cdata_*
    or svn_xml_escape_attr_* as appropriate.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+Ob8whDAgUT1yirARAvsjAJ4rzkb2K/G5Bvnw4zQfVL2HhQbRQwCffdIm
+sQOB9iiZUxQLZxZEUrSgEY=
=oFhW
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org