Re: svn commit: rev 4651 - branches/issue-650-ssl-certs/subversion/libsvn_ra_dav

Karl Fogel wrote:

mass@tigris.org writes:
  

Log:
Adjusted symbols which began with an ssl prefix, to make it clearer that they
are not part of the OpenSSL library.

* subversion/libsvn_ra_dav/session.c:
  (struct svn_ssl_verify_baton_t) : Renamed from ssl_verify_baton_t.
  (svn_ssl_set_verify_callback) : Renamed from ssl_set_verify_callback,
  adjusted for other symbol name changes.
  (svn_ra_dav__open) : Adjusted for above.
    

Just some minor comments:

Internal symbols should use the double-underscore convention,
otherwise they look like part of Subversion's public interfaces (such
as the ones in include/svn_*.h). There's a bit in HACKING about this.

Thus

   svn_ssl__set_verify_callback()

etc.

I thought this was only for exported symbols (this function is declared
static.) Perhaps a svn_ prefix implies that it is exported, and I
should have called it 'verify_ssl_callback' or gone ahead and called it
'svn_ra_dav__ssl_verify_callback'?

-David Waite

Reviewing the whole branch is on my todo list; apologies that can't
get to it right away, just got a few burners going at the moment.

Thats fine; I'm just wrapping my head around libsvn_auth before I start
on the client certificate authentication.

-David Waite

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:25:59 2006