Re: svn commit: rev 4621 - in trunk/subversion: include libsvn_client clients/cmdline svnversion

Garrett Rooney wrote:

 the only thing i've thought of caching in the context object is
 possibly the parsed config files, so we can avoid reparsing them every
 time we need a config option. do people think this is worthwhile?
 one issue with this is that we parse the config files in places other
 than libsvn_client, so either we'd have to pass the context object
 down into other libraries or we'd have to explicitly pass the config
 data we got from the context object into the other libraries.

 what do people think?

Actually, we should parse the config files (or create the svn_config_t's
some other way) in the _client_, not in libsvn_client. Our libraries
should not parse the config files themselves, ever. It's the client's
responsibility to donfigure the libraries, not the other way around.

-- 
Brane Čibej   brane_at_xbc.nu   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org