Re: svn commit: rev 4621 - in trunk/subversion: include libsvn_client clients/cmdline svnversion

Garrett Rooney rooneg@electricjellyfish.net writes:

  Eek. This code is *inside* libsvn_client. Our typical pattern is that a
  structure is opaque outside the library, but completely visible
  inside the library. Thus, we don't need to use getters/setters within the
  library. The code can simply refer to ctx-auth_baton.
 
 i could go either way on this. keeping it opaque seemed like a
 reasonable idea so that we could easily add new things to it in the
 future (post-1.0) while still remaining binary compatability, but
 realistically, if we're adding new callbacks or something keeping
 binary compatability might be pointless if we're breaking semantic
 compatability.

Binary compatability isn't really important here, but there is another
reason why you may want to keep it opaque and that's if anything gets
cached in the structure. For example, the svn_wc_adm_access_t access
baton is opaque to libsvn_wc, it caches the entries file and the
interface is responsible for maintaining the cache. Of course the
structure doesn't have to be opaque for you to do this, but being
opaque ensures that your caching mechanism cannot easily be bypassed.

To be honest svn_wc_adm_access_t doesn't have a particularly good
interface (I have a plan to improve it) but the principle is clear.
Then again, I am really a C++ programmer with all the baggage that
entails...

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org