Re: [PATCH] Fix issue 1037 (Repository UUIDs)

mark benedetto king wrote:

The first record in this table is considered the
repository's own UUID. This value is preserved across dump/load
cycles. If one wants to load without changing the UUID, it can
simply be removed from dump file (it is always the third line).

Wouldn't it be better to pass a flag to svnadmin load to make it ignore
that record? The dump file could be huge, which would make it a bit of a
pain to edit it. The UUID in the dump file should be ignored during
incremental loads, too -- or perhaps not written during incremental writes.

+/* UUID manipulation. */
+
+/** Populate @a *uuid with the UUID associated with @a fs.
+ *
+ * Populate @a *uuid with the UUID associated with @a fs.
+ */

Why the repeated docstrings? If we want the brief descriptions repeated,
we should say so in doxygen.conf (the REPEAT_BRIEF option). It's
currently set to NO.

Apart from that, the patch looks complete to my short-sighted eyes.

-- 
Brane Čibej   brane_at_xbc.nu   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org