[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Fix issue 1118 - Second Try

From: <peter_at_pdavis.cx>
Date: 2003-01-28 19:49:34 CET

Hash: SHA1

On Tuesday 28 January 2003 07:29, cmpilato@collab.net wrote:
 Nice work. A few cleanups and it's good to go. Care to resubmit?

I agree with all your suggested changes. I should have asked about the
argument order first, though, cuz that's a lot of work :-) (smacks head).
Log message:

Fix for issue 1118: properly escape whitespace in XML attribute
values, and update all callers of svn_xml_escape_* to pass the new

* libsvn_subr/xml.c (xml_escape):
  New argument is_attribute. If escaping an attribute, additionally
  escape spaces, tabs, newlines, and carriage returns. Don't escape
  single- or double-quotes unless escaping an attribute.

* libsvn_subr/xml.c, include/svn_xml.h
  (svn_escape_string, svn_escape_cstring, svn_escape_stringbuf):
  New argument is_attribute, passed verbatim to xml_escape.

* mod_dav_svn/deadprops.c, clients/cmdline/log-cmd.c,
  libsvn_ra_dav/commit.c, libsvn_ra_dav/fetch.c:
  Update callers of svn_escape_* to use new is_attribute arg, passing TRUE
  or FALSE as appropriate.

- --
Peter Davis
Version: GnuPG v1.2.1 (GNU/Linux)


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

  • text/x-diff attachment: diff
Received on Sat Oct 14 02:22:31 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.