[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: New entries file format.

From: <cmpilato_at_collab.net>
Date: 2003-01-28 08:05:13 CET

cmpilato@collab.net writes:

 Peter Davis peter@pdavis.cx (by way of Peter Davis peter@pdavis.cx) writes:
 
  As I said in the issue, would you mind if I wrote this patch, if you
  haven't already started (with the addition of numeric character refs in
  xml_unescape)?
 
 As I said in the issue, it's all you, baby, and as far as I'm
 concerned, the xml_unescape routines can be removed altogether as
 unused cruft -- M-x tags-search svn_xml_unescape shows only the
 prototypes and implementations to me, no actual callers of the
 interface. The only reason to keep them around might be for symmetry
 of interface, but that's not much of a reason, in my opinion.

Oh, and just an unsolicited reminder to read the HACKING file
regarding the formatting of log messages and patch submission and
such. If you go with the unescape interface removal, you might
consider making that a separate patch (since it has no logical
connection to fixing the escape routines).

Awaiting your work,
--C-Mike.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:21:26 2006

This is an archived mail posted to the Subversion Dev mailing list.