[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_client_ctx_t (was Re: Issue #1004 and Garrett Rooney)

From: <rooneg_at_electricjellyfish.net>
Date: 2003-01-26 02:51:17 CET

On Saturday, January 25, 2003, at 12:16 PM, Karl Fogel wrote:

 Garrett Rooney rooneg@electricjellyfish.net writes:
 cause it's easier to just move around existing functionality while i'm
 thinking about how to best do the cancelation stuff, and this stuff
 should get moved anyway ;-)

 Gotcha. :-)

another reason to move the existing callbacks and batons into a context
parameter (if we're going to have a context parameter, which it seems
like everyone agrees is a good idea) is that getting it over with ASAP
means we get the API change out of the way now, minimizing the number
of third party projects that have to deal with it... at the moment we
have a small number of consumers outside of the svn command line
client, but that number is growing quickly.

anyway, here's my current patch. i haven't run 'make check' lately
(since changing the property functions), but it most likely works. i
don't have the energy to update the log message at the moment, so just
take the previous one, and extrapolate out to include all the other
functions in svn_client.h that had auth_baton parameters.

the only other thing i want to do with this (other than testing it
more) is to possibly add an svn_context_t parameter to
svn_opt_subcommand_t, since all the svn_client_* functions take one,
and it seems silly to have the code to create it and set the auth_baton
in each subcommand.

as always, i'd welcome any input people have, as i'd like to get it
into the tree soon so that i can move on to work on the other parts of
this issue.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sat Oct 14 02:17:59 2006

This is an archived mail posted to the Subversion Dev mailing list.