Re: [PATCH] svn_client_ctx_t (was Re: Issue #1004 and Garrett Rooney)

On Saturday, January 25, 2003, at 12:15 AM, Karl Fogel wrote:

 I don't think the client_ctx_t baton itself would ever get passed down
 into libsvn_wc; but some of the things *in* the baton might be passed
 as individual arguments to libsvn_wc functions, of course.

in retrospect, that does make more sense.

 the first thing i thought would be nice to move was the
 svn_client_auth_baton_t's that get passed to everything that accesses
 the repository directly. i've got a first cut at that done, just
 doing so for svn_client_checkout (and the functions were affected by
 that change, progressing only far enough to make things build and pass
 make check).

 assuming people like this approach, i was going to finish up moving
 the auth batons in, then get the patch to the point where it can be
 committed, commit it, then move on to the notification functions, and
 probably config options after that (since that requires the context
 object to be passed much further down the chain).

 after all this is done, then i'll start looking at doing the
 cancelation stuff, which is the whole point of this exercise, if you
 remember the issue at hand ;-)

 Is there any reason not to start with the cancellation stuff, and then
 do the other stuff? It all has to get done, sure, but at least that
 way we'd grow the new feature earlier :-).

 Your call, just pointing out the possibility.

cause it's easier to just move around existing functionality while i'm
thinking about how to best do the cancelation stuff, and this stuff
should get moved anyway ;-)

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:17:05 2006