[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Rename fun and Philip's patch

From: <philip_at_codematters.co.uk>
Date: 2003-01-24 20:00:08 CET

Bill Tutt rassilon@lyra.org writes:

 * Use of svn_fs_compare_ids in the test case: This function always
 annoys me, it falls back to calling svn_fs_check_related if the ids
 aren't exactly equal. Needless to say, this test case shouldn't be this
 fuzzy.

The test checks if svn_fs_compare_ids returns zero, which only happens
when the ids are equal. What's fuzzy about that? Yes, it might be
more efficient to call some are they equal function, one that
returned a simple yes/no answer, but I didn't see one in the public
interface.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:15:08 2006

This is an archived mail posted to the Subversion Dev mailing list.