Re: svn commit: rev 4530 - in trunk/subversion: include libsvn_auth

Greg Stein gstein@lyra.org writes:

 You can simplify the allocations and whatnot by storing provider_t
 structures into the array, rather than provider_t pointers.

I get this feedback from you all the time, I'm starting to feel like
it's a clash of bikeshed coding styles rather than an issue of real
correctness.

Whenever I'm in a scenario that involves creating multiple levels of
nested structures, you always advocate storing *full* structures
whereever possible. And certainly, this style does make allocation
much easier: a single pcalloc builds the whole shebang. No need for
repeated pcallocs at every level.

But the downside is that I find this makes it harder to *use* the
levels of nested structures. I'm trying to get or set data, and I
find myself crawling through our declarations, trying to remember
whether to use '-' or '.' to access sub-structures at every level.
It's the mixture of pointers and real structs that drives me nuts.
That's why I prefer the everything is a pointer system. It's more
work to allocate, but much simpler to navigate IMO.

Perhaps I'm philosophizing too much. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:14:06 2006