[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: svn add horkage (and exposing libsvn_wc's ignore functionality)

From: <kfogel_at_newton.ch.collab.net>
Date: 2003-01-24 16:29:07 CET

Eric Gillespie epg@pretzelnet.org writes:
 DOH! That isn't the only problem with that patch... I put the
 patch into the message i was composing before the build/check
 finished and never replaced it with the correct patch, which is
 included below.

:-). Been there.

  Also, if you have time to add a regression test, that would be great.
  Should be pretty short simple, for this.
 Yeah, OK. I've never peeked into Subversion's test suite before.
 I'll try to come up with something tomorrow night.

Okay, will wait for that.

This may seem like nit-picking, but it's a big help: please include
the full log message with every posting of a patch. Otherwise, the
reviewer has to hunt down old log message and guess whether it still
applies (while knowing that the new patch is at least slightly
different from the old one, or it wouldn't have been reposted...)

Keeping patches self-contained and travelable makes the whole system
a bit easier.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:13:45 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.