Semantics of svn_auth_save_credentials?

Within svn_auth.h, we have:

/** Save a set of credentials.
 *
 * Ask @a auth_baton to store @a credentials (of type @a cred_kind)
 * for future use. Presumably these credentials authenticated
 * successfully. Use @a pool for temporary allocation. If no
 * provider is able to store the credentials, return error.
 */
svn_error_t * svn_auth_save_credentials(const char *cred_kind,
                                        void *credentials,
                                        svn_auth_baton_t *auth_baton,
                                        apr_pool_t *pool);

I have to say that the implied semantics trouble me. Exactly what
provider should 'save' a particular credential? The first provider?
All of them?

I'd also suggest that a provider be allowed to have a NULL function
pointer to save_credentials rather than implement a stub that returns
false. That makes it much easier for providers - a little more work
for the caller perhaps. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:12:32 2006