[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4550 - trunk/subversion/bindings/swig

From: <gstein_at_lyra.org>
Date: 2003-01-24 02:47:26 CET

On Thu, Jan 23, 2003 at 06:02:08PM -0600, kfogel@tigris.org wrote:
 Author: kfogel
 Date: 2003-01-23 18:01:54 -0600 (Thu, 23 Jan 2003)
 New Revision: 4550
 
 Modified:
    trunk/subversion/bindings/swig/svn_wc.i
 Log:
 Patch from Jon Trowbridge. This looks correct to me, but if a
 swigxpert could glance over it, that would be great.

No, it is incorrect. We return hash tables in several places. But those hash
tables should be mapped into Python dictionaries, rather than left as raw
hash tables.

For example, see the code in svn_client.i to process the return values for
svn_client_status() and svn_client_ls().

The raw 'apr_hash_t *' isn't useful to the languages since we don't have
access to APR's hash functions. And besides, we really want to take
advantage of Python's native dictionary type.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:11:09 2006

This is an archived mail posted to the Subversion Dev mailing list.