[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] svn_ra_svn_write_cmd format string bug

From: <epg_at_pretzelnet.org>
Date: 2003-01-24 02:36:06 CET

svn was segfaulting in prop_tests 11 using ra_svn. I stepped
through it with gdb and found this bug. The test tries to set a
property on revision 0. The svn_revnum_t is cast to
apr_uint64_t, where it somehow turned from 0 into
581318566473629696.

The patch fixes that, but the test still fails due to the
apr_proc_wait issue i raised elsewhere (when i change
apr_proc_wait to check for EINTR and loop it passess, marking the
first time i've had the entire test suite pass over ra_svn).

Index: subversion/libsvn_ra_svn/client.c
===================================================================
--- subversion/libsvn_ra_svn/client.c (revision 4549)
+++ subversion/libsvn_ra_svn/client.c (working copy)
@@ -424,7 +424,7 @@
   svn_ra_svn_conn_t *conn = sess;
   apr_pool_t *pool = conn-pool;
 
- SVN_ERR(svn_ra_svn_write_cmd(conn, pool, change-rev-prop, ncs,
+ SVN_ERR(svn_ra_svn_write_cmd(conn, pool, change-rev-prop, rcs,
                                rev, name, value));
   SVN_ERR(svn_ra_svn_read_cmd_response(conn, pool, ));
   return SVN_NO_ERROR;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:11:04 2006

This is an archived mail posted to the Subversion Dev mailing list.