Eric Gillespie epg@pretzelnet.org writes:
OK, here's the preliminary patch. I haven't documented the
function yet, but i wanted to ask some questions first. Where
should the new functions go?
Aw heck, what does not knowing where it lives have to do with
documenting the interfaces? :-) No log message no docs just raises
the reviewability bar, i.e., lowers the probability that someone will
look at it.
I looked at it anyway, though, so the probability is now 100% :-).
Just pointing it out for next time.
They are currently in svn_wc
because that is where the original get_default_ignores function
was. But notice that it doesn't use any other svn_wc
functionality; as a matter of fact it only uses svn_config.
Should it go there?
I think that would be fine.
We could put it in svn_client.h, the idea being that client
implementations might want to ask about this list, and they should get
it from there instead of all the down in svn_wc.h. But then I suppose
we'd have to pass the list down into all the wc code paths that might
need it, and wc would still need to call the is_ignored() function on
the list, which would be a semi-weird layering interaction if that
function were back up in svn_client.
(I just composed and erased a whole mail saying why I didn't think it
belonged in libsvn_wc, then decided that was stupid and you were
right. Not that wc would necessarily be wrong, of course.)
Other than that, how does it look?
Looks good!
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:10:56 2006