Re: svn commit: rev 4532 - in trunk/subversion: include libsvn_wc libsvn_ra_local libsvn_client mod_dav_svn libsvn_ra_svn libsvn_repos libsvn_ra_dav svnserve

Karl Fogel kfogel@newton.ch.collab.net writes:

 Branko ÄŒibej brane@xbc.nu writes:
  Philip Martin wrote:
 
  I am seeing massive regression test failures with this patch when I
  enable APR pool debugging.
  
  I can confirm this, it's happening on Windows, too.
 
 Yup. Mike Pilato is fixing the change in-place right now. (If it
 starts looking like it'll take a non-finite amount of time to fix,
 then he'll revert the whole thing and work on it offline.)

I was about to commit this

* svn/subversion/libsvn_wc/adm_crawler.c (report_revisions): Dup the strings
  that need to persist between directory entries.

Index: ../svn/subversion/libsvn_wc/adm_crawler.c
===================================================================
--- ../svn/subversion/libsvn_wc/adm_crawler.c (revision 4535)
+++ ../svn/subversion/libsvn_wc/adm_crawler.c (working copy)
@@ -232,9 +232,11 @@
         svn_path_add_component (this_url_s,
                                     svn_path_uri_encode (key, child_subpool));
 
- this_path = this_path_s-data;
- this_full_path = this_full_path_s-data;
- this_url = this_url_s-data;
+ this_path = apr_pstrmemdup (subpool, this_path_s-data,
+ this_path_s-len);
+ this_full_path = apr_pstrmemdup (subpool, this_full_path_s-data,
+ this_full_path_s-len);
+ this_url = apr_pstrmemdup (subpool, this_url_s-data, this_url_s-len);
       }
       
       /* The Big Tests: */

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org