[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] svn log date string

From: <ukai_at_debian.or.jp>
Date: 2003-01-23 06:02:36 CET

Hi,

svn log shows human unreadable date string if I use it in LANG=ja_JP.eucJP,
looks like:

------------------------------------------------------------------------
rev 546: ukai | 2003-01-22 17:20:05 +0900 (?\191?\229, 22 1?\183?\238 2003) | 1 line

This is because log_message_receiver() in log-cmd.c convert
date cstring to cstring from utf8 but it is already cstring not utf8.
With attached patch, it works fine for me.

Regards,
Fumitoshi UKAI

Log:
 * subversion/clients/cmdline/log-cmd.c
  (log_message_receiver): no need to convert date to cstring from utf8.
        svn_time_to_human_cstring already returns cstring, it's not utf8.

Index: subversion/clients/cmdline/log-cmd.c
===================================================================
--- subversion/clients/cmdline/log-cmd.c (revision 4508)
+++ subversion/clients/cmdline/log-cmd.c (working copy)
@@ -205,16 +205,10 @@
       apr_time_t time_temp;
       
       SVN_ERR (svn_time_from_cstring (time_temp, date, pool));
- date = svn_time_to_human_cstring(time_temp, pool);
+ date_native = svn_time_to_human_cstring(time_temp, pool);
     }
   else
- date = (no date);
-
- err = svn_utf_cstring_from_utf8 (date_native, date, pool);
- if (err (APR_STATUS_IS_EINVAL (err-apr_err))) /* unlikely! */
- date_native = svn_utf_cstring_from_utf8_fuzzy (date, pool);
- else if (err)
- return err;
+ date_native = (no date);
 
   if (! lb-quiet)
     {

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:08:52 2006

This is an archived mail posted to the Subversion Dev mailing list.