Re: [PATCH] Re: svn co svn://... gets confused by errors in RC file

Garrett Rooney rooneg@electricjellyfish.net writes:

 committed in revision 4509, although i put the output parameter before
 the pool parameter, rather than after, since most of our code i've seen
 takes the pool as the last argument.

Thanks, the patch had a bug. Log message and new patch below.

* subversion/libsvn_ra_svn/client.c:

  (ra_svn_open): Initialize tunnel_agent before using it.

Index: subversion/libsvn_ra_svn/client.c
===================================================================
--- subversion/libsvn_ra_svn/client.c (revision 4509)
+++ subversion/libsvn_ra_svn/client.c (working copy)
@@ -295,6 +295,7 @@
     return svn_error_createf(SVN_ERR_RA_ILLEGAL_URL, NULL,
                              Illegal svn repository URL %s, url);
 
+ tunnel_agent = NULL;
   SVN_ERR( find_tunnel_agent(hostname, tunnel_agent, pool) );
   if (tunnel_agent)
     {

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:07:35 2006