[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix compiler warnings

From: <gstein_at_lyra.org>
Date: 2003-01-21 21:32:11 CET

On Tue, Jan 21, 2003 at 12:19:37PM -0800, Blair Zajac wrote:
 cmpilato@collab.net wrote:
  Blair Zajac blair@orcaware.com writes:
   cmpilato@collab.net wrote:
...
    I disagree. This is a collection of bytes, treated as bytes, not as
    characters. I believe APR's typing choice to be a) more accurate, and
    b) more revealing about the usage for the data. 'char *' looks like
    something that's human-readable -- these digest are not.
  
   Why not use void * then?
  
  Why bother? 'unsigned char' is, as far as I know, the way to
  represent 8 bits of data. This has been the case in every piece of
  software I've ever worked on.
  
  You wanna change APR?
 
 No, definitely don't want to go there. :)

Hunh? It isn't like APR is a minefield. Sheesh.

I've updated apr-util/include/apr_md5.h and crypto/apr_md5.c. The prototype
now takes a const void * for apr_md5_update() and apr_md5().

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:04:48 2006

This is an archived mail posted to the Subversion Dev mailing list.