Re: [PATCH] Fix compiler warnings

Karl Fogel kfogel@newton.ch.collab.net writes:

  Perhaps the bigger question is whether to somehow fix the apr_md5_*
  API to take char*'s instead? I'm sort of on the fence here. Before
  starting what will most likely be a painful discussion on dev@apr,
  I'd like to see what you guys (namely Karl since he wrote most of the
  checksum code that uses MD5) think first. What makes more sense?
 
 I have to admit, it makes more sense to me to fix APR. I mean, most
 callers are probably passing signed 'char *' data. If APR's md5 code
 internally needs to treat it as unsigned, for the purpose of the
 digest update algorith, it should just cast.

I disagree. This is a collection of bytes, treated as bytes, not as
characters. I believe APR's typing choice to be a) more accurate, and
b) more revealing about the usage for the data. 'char *' looks like
something that's human-readable -- these digest are not.

 No, I never saw any warnings about it, not from GCC 2.96 anyway.

I get warning on Windows in MSVC6, but not from GCC.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:04:36 2006