[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4463 - in trunk/subversion: mod_dav_svn libsvn_repos libsvn_ra_dav

From: <gstein_at_lyra.org>
Date: 2003-01-20 20:37:24 CET

On Mon, Jan 20, 2003 at 10:53:58AM -0600, kfogel@tigris.org wrote:
...
 + if (memcmp (target_digest, zeros_digest, MD5_DIGESTSIZE) != 0)
 + target_hex_digest = svn_md5_digest_to_cstring (target_digest, subpool);

I just thought of something.

We keep seeing the above pattern. Should we just put that check into the
semantics of svn_md5_digest_to_cstring() ? (i.e. have it return NULL if the
input is all zeroes)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 14 02:02:55 2006

This is an archived mail posted to the Subversion Dev mailing list.