Re: svn commit: rev 4399 - in branches/issue-1003-dev/subversion: libsvn_fs libsvn_fs/bdb libsvn_fs/util tests/libsvn_fs

Garrett Rooney <rooneg@electricjellyfish.net> writes:

> On Wednesday, January 15, 2003, at 06:59 PM, Branko Čibej wrote:
> > Ouch! You've got a bunch of files that have changed all the line
> > endings
>
> > in this commit. Talk about useless diffs...
> >
> > "svnlook diff" should pass --strip-trailing-cr to diff, so that an
> > eol-style change doesn't hide what's going on.
>
> didn't we just change the svn:eol-style on the whole repository to
> avoid this problem?

Ahh, but Bill committed strange stuff to the branch in r4391. At that
stage his working copy had CRCRLF line endings (due to some problem
with GNU diff on Windows I believe), and so the commit sent CRLF to
the repository. A normal file with svn:eol-style set to native has LF
line endings in the repository.

My guess is that when you check-out the branch on Windows the
repository CRLF gets "converted" to CRLF in the working copy, (I know
when you check out the branch on Unix the CRLF gets converted to
LF). A subsequent commit will convert that to LF when it sends it back
to the repository. Most of the issue-1003-dev branch has been broken
since r4391. The files committed in rev 4399 have been "fixed" of the
problem created by rev 4391. Whether such "fixing" should happen is
another matter.

eol-conversion has no place in version control :)

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org