[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4396 - in trunk/subversion: svnadmin libsvn_repos

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-01-16 01:20:57 CET

On Wed, Jan 15, 2003 at 02:25:28PM -0600, sussman@tigris.org wrote:
> Author: sussman
> Date: 2003-01-15 14:25:18 -0600 (Wed, 15 Jan 2003)
> New Revision: 4396
>
> Modified:
> trunk/subversion/libsvn_repos/repos.c
> trunk/subversion/svnadmin/main.c
> Log:
>
> Fix two small annoyances with 'svnadmin recover'.
>
> * repos.c (svn_repos_recover): if the db lockfile is already
> unlocked, don't freak out. move on to the recovery step.
>...
> +++ trunk/subversion/libsvn_repos/repos.c Wed Jan 15 14:25:25 2003
> @@ -977,7 +977,7 @@
> "svn_repos_recover: error opening db lockfile");
>
> apr_err = apr_file_unlock (lockfile_handle);
> - if (apr_err)
> + if (apr_err && ! APR_STATUS_IS_EACCES(apr_err))
> return svn_error_createf
> (apr_err, NULL,
> "svn_repos_recover: failed to delete all locks on repository `%s'.",

Of course it will freak out. You can't necessarily unlock the lock file from
a different process. I just looked at this code, and I really don't
understand what the heck it is attempting.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jan 16 01:19:17 2003

This is an archived mail posted to the Subversion Dev mailing list.