Re: [PATCH] make symlinked hook scripts work again

Josef Wolf <jw@raven.inka.de> writes:

> * subversion/libsvn_subr/io.c
> (svn_io_check_path): Add boolean parameter 'resolve_symlinks' to
> decide whether the target of a symlink or the symlink itself should
> be checked.

Apologies, I forgot to comment on the previous patch.

Even when/if Subversion starts to version symbolic links it will be
rare for the code to allow some path to be either a file or a link.
In most cases things that should be files cannot be links, and things
that should be links cannot be files. Thus I'm not sure adding a
boolean parameter is the best solution, perhaps the svn_io_check_path
interface should remain unchanged, and there should be a function with
a different name but the same parameters that provides the
resolve_symlinks == TRUE behaviour. (These functions could call a
common helper function of course.)

I don't know if this is better, but it should be considered.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org