[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] run hook-scripts on WIN32

From: <rbb_at_rkbloom.net>
Date: 2003-01-13 18:14:32 CET

On 13 Jan 2003, Ben Collins-Sussman wrote:

> Philip Martin <philip@codematters.co.uk> writes:
>
> > "Chris Foote" <Chris.Foote@xtra.co.nz> writes:
> >
> > > This patch, from rev 4328, gets the hooks working on WIN32 by checking for a
> > > script
> > > with an .exe, .cmd or .bat extentsion.
> >
> > I'm not really interested in Windows ;) but why can't you just have a
> > fixed name for the script? Can that script not then invoke any other
> > program using any name/extension/path you care to choose? Why is it
> > necessary for Subversion to do this processing? It's not as if it's a
> > setting that every repository user will want to customise, it's only
> > the repository administrator that deals with it.
>
> Wow, that's a really good point, Philip.
>
> Can APR (running on win32) launch a program with an arbitrary name?

Unfortunately, no. APR just calls the native Windows CreateProcess call,
so if Windows can't do it, neither can APR. The best thing you could do,
IMNSHO, is to just hard-code this to $(unix_script_name).bat on Windows.
This allows the Windows environment to do the right thing, and it removes
all the checks from the SVN code. The only problem with it, is that most
Windows developers consider batch files an incredible hack.

Ryan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jan 13 18:01:24 2003

This is an archived mail posted to the Subversion Dev mailing list.