Re: svn commit: rev 4347 - in trunk/subversion: libsvn_client tests/clients/cmdline tests/clients/cmdline/svntest

Philip Martin wrote:

>kfogel@tigris.org writes:
>
>
>
>>* subversion/tests/clients/cmdline/svntest/main.py
>> (chmod_tree.visit): Don't try to chmod links.
>>
>>
>
>Good, that fixes one of my problems :)
>
>
>
>>Modified: trunk/subversion/tests/clients/cmdline/commit_tests.py
>>==============================================================================
>>--- trunk/subversion/tests/clients/cmdline/commit_tests.py (original)
>>+++ trunk/subversion/tests/clients/cmdline/commit_tests.py Sat Jan 11 15:41:28 2003
>>@@ -1499,6 +1499,34 @@
>> if svntest.actions.run_and_verify_status(wc2_dir, expected_status2):
>> return 1
>>
>>+
>>+def commit_symlink(sbox):
>>+ "committing a symlink should fail"
>>+
>>+ # Symlinks are a Unix phenonenon anyway.
>>+ if svntest.main.windows:
>>+ return 0
>>
>>
>
>Should this be done using Skip(commit_symlink, svntest.main.windows)
>in the list of tests?
>
>

Almost; It should be using Skip(commit_symlink, os.name != 'posix').
Platform tests do not belong in the testcases, they belong in the test list.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org