[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] mailer.py smtplib support

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-01-11 11:08:05 CET

On Fri, Jan 10, 2003 at 07:47:58PM -0800, Matt Kraai wrote:
> On Fri, Jan 10, 2003 at 07:21:50PM -0800, Greg Stein wrote:
> > It still isn't quite right, tho, as some headers need to be inserted for it
> > to look right (i.e. the "Author: gstein" is interpreted as a msg header
> > rather than part of the body).
>
> This should be fixed in revision 4338.

Thanks :-)

I fixed it again in 4342 (and got a conflict error when I try to commit :-).
The new code can generate the commit message through one of three means (in
order of preference):

  1. via a pipe to an MDA
  2. via SMTP to an MDA
  3. to stdout

In each case, we also optimize how the "diff" process is run. It is nice an
efficient (Python isn't in the way) for the latter two choices. For SMTP,
though, we read everything into memory, then chunk it all out.

Now for some additional tweaks and for configurability...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 11 11:06:58 2003

This is an archived mail posted to the Subversion Dev mailing list.